Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
39426: roachtest: add large cluster weekly kv tests r=ajwerner a=ajwerner

This PR adds two weekly kv roachtests. The weekly roachtest script should
upload the data appropriately store the data in roachperf.

Release note: None

Co-authored-by: Andrew Werner <[email protected]>
  • Loading branch information
craig[bot] and ajwerner committed Aug 8, 2019
2 parents a897b9c + 5be3419 commit c8d4a59
Showing 1 changed file with 14 additions and 1 deletion.
15 changes: 14 additions & 1 deletion pkg/cmd/roachtest/kv.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ func registerKV(r *testRegistry) {
blockSize int
encryption bool
sequential bool
duration time.Duration
tags []string
}
runKV := func(ctx context.Context, t *test, c *cluster, opts kvOptions) {
nodes := c.spec.NodeCount - 1
Expand All @@ -48,7 +50,10 @@ func registerKV(r *testRegistry) {
m.Go(func(ctx context.Context) error {
concurrency := ifLocal("", " --concurrency="+fmt.Sprint(nodes*64))
splits := " --splits=1000"
duration := " --duration=" + ifLocal("10s", "10m")
if opts.duration == 0 {
opts.duration = 10 * time.Minute
}
duration := " --duration=" + ifLocal("10s", opts.duration.String())
readPercent := fmt.Sprintf(" --read-percent=%d", opts.readPercent)
histograms := " --histograms=" + perfArtifactsDir + "/stats.json"
var batchSize string
Expand Down Expand Up @@ -115,11 +120,18 @@ func registerKV(r *testRegistry) {
// Configs with a sequential access pattern.
{nodes: 3, cpus: 32, readPercent: 0, sequential: true},
{nodes: 3, cpus: 32, readPercent: 95, sequential: true},

// Weekly larger scale configurations.
{nodes: 32, cpus: 8, readPercent: 0, tags: []string{"weekly"}, duration: time.Hour},
{nodes: 32, cpus: 8, readPercent: 95, tags: []string{"weekly"}, duration: time.Hour},
} {
opts := opts

var nameParts []string
nameParts = append(nameParts, fmt.Sprintf("kv%d", opts.readPercent))
if len(opts.tags) > 0 {
nameParts = append(nameParts, strings.Join(opts.tags, "/"))
}
nameParts = append(nameParts, fmt.Sprintf("enc=%t", opts.encryption))
nameParts = append(nameParts, fmt.Sprintf("nodes=%d", opts.nodes))
if opts.cpus != 8 { // support legacy test name which didn't include cpu
Expand Down Expand Up @@ -147,6 +159,7 @@ func registerKV(r *testRegistry) {
Run: func(ctx context.Context, t *test, c *cluster) {
runKV(ctx, t, c, opts)
},
Tags: opts.tags,
})
}
}
Expand Down

0 comments on commit c8d4a59

Please sign in to comment.