Skip to content

Commit

Permalink
Update patch set 15
Browse files Browse the repository at this point in the history
Patch Set 15:

> Patch Set 13:
> 
> > Patch Set 13:
> > 
> > > Patch Set 13: Code-Review+1
> > > 
> > > > Patch Set 13:
> > > > 
> > > > For the options, 1) might require a lot of changes and I'm not sure if it should be part of this task. For 2) and 3), you probably have a better idea which would be the best option.
> > > 
> > > In that case I'd lean towards just using the "increasing quality" order, since using different orders in different places would be pretty confusing and bug-prone. In that case, this LGTM, though I'd recommend documenting how simulcast config works somewhere (above RtpSenderInterface::SetParmaeters?).
> > 
> > Chrome might have to reverse the order. I'll raise a spec bug pointing out that the order is not clear.
> 
> Filed w3c/webrtc-pc#1896

Is it ok to land this CL?

Patch-set: 15
Reviewer: Gerrit User 5492 <5492@58829da1-049c-39fb-b951-ebdcd0984767>
  • Loading branch information
Gerrit User 5492 authored and Gerrit Code Review committed Jun 15, 2018
1 parent bea53b4 commit bf5a17d
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit bf5a17d

Please sign in to comment.