Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Dependabot PRs that update multiple dependencies #213

Closed
ChristopherBeltran opened this issue Nov 15, 2023 · 8 comments · Fixed by #216
Closed

Add support for Dependabot PRs that update multiple dependencies #213

ChristopherBeltran opened this issue Nov 15, 2023 · 8 comments · Fixed by #216
Milestone

Comments

@ChristopherBeltran
Copy link
Contributor

Occasionally Dependabot will open up a PR that attempts to update multiple dependencies(In my experience I have only seen it attempt to update two dependencies, not sure if it will ever attempt more):
Screenshot 2023-11-14 at 5 13 57 PM

These PRs will cause the action to fail with an error: Unable to extract entry from pull request title!

@dangoslen
Copy link
Owner

dangoslen commented Nov 15, 2023 via email

@dangoslen
Copy link
Owner

@ChristopherBeltran is that PR you mentioned public by chance? Just wanting to dig a bit more into what the format/structure of everything looks like

@ChristopherBeltran
Copy link
Contributor Author

@dangoslen It's not public unfortunately. But if there's anything specific I can pull from it that could be helpful I'd be happy to do so.

@stevehipwell
Copy link

@dangoslen you could enable a Dependabot group in this repo and then test it here?

updates:
  - package-ecosystem: github-actions
    directory: /
    groups:
      github-actions:
        patterns:
          - "*"
        update-types:
          - minor
          - patch

@dangoslen
Copy link
Owner

I believe I have the changes needed for this in main. An example is #211 which bumps jest and the associated jest types.

@ChristopherBeltran could you take a look?

@dangoslen dangoslen added this to the v3.7.0 milestone Nov 25, 2023
@dangoslen dangoslen linked a pull request Nov 25, 2023 that will close this issue
@ChristopherBeltran
Copy link
Contributor Author

ChristopherBeltran commented Nov 27, 2023

I believe I have the changes needed for this in main. An example is #211 which bumps jest and the associated jest types.

@ChristopherBeltran could you take a look?

@dangoslen I think we're almost there. I see the entries are duplicated:
Screenshot 2023-11-27 at 10 55 57 AM

One entry appears to be surrounded by a single ` while the second is surrounded by two ``

@dangoslen
Copy link
Owner

I believe I corrected that in a follow-up PR #217. The first run did not remove the extra backticks, and the second one did - which makes the updates look like a duplicate.

@ChristopherBeltran
Copy link
Contributor Author

Great, I think we are good then 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants