Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run yarn and yarn declarations #trivial #204

Merged
merged 1 commit into from
Mar 29, 2017
Merged

Run yarn and yarn declarations #trivial #204

merged 1 commit into from
Mar 29, 2017

Conversation

macklinu
Copy link
Member

I ran yarn declarations to update the danger.d.ts file with the typo fix from #195. Greenkeeper PRs like #202 are "failing" because of the yarn declarations check in our dangerfile. (I also think #200 relates to this.)

Also, when I just ran yarn on master, it updated the yarn.lock file, which I think more appropriately reflects our package.json (for example, yarn.lock now shows ts-node 3.x, which is also present in our package.json).

Once this is merged, I can merge master back into #201, #202, and #203 to get them passing. 👍

@orta
Copy link
Member

orta commented Mar 29, 2017

Ah! Yeah. My bad, I expected merging #194 to take less time than it did. Basically this https://twitter.com/orta/status/846083534909530115

@codecov-io
Copy link

Codecov Report

Merging #204 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #204   +/-   ##
=====================================
  Coverage       0%     0%           
=====================================
  Files           4      4           
  Lines         104    104           
  Branches       16     16           
=====================================
  Misses        104    104

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1329527...8ff7d16. Read the comment docs.

@macklinu
Copy link
Member Author

No worries, @orta. Thanks for the 👍

@macklinu macklinu merged commit 749728c into master Mar 29, 2017
@macklinu macklinu deleted the yarn-stuff branch March 29, 2017 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants