-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring cmake build up to parity with autotools and add documentation #24
Conversation
Current approach causes issues on Windows with Ninja generator, for instance.
To help external cmake projects find and use ccd.
I added a CMake build to |
I have a suggestion on configuring CMake config file and version file for libccd. CMake provides a helper function that can automatically generate those files. Using the function would be less buggy rather than maintaining the manual files manually. |
Sure, if you prefer. I always deliberately avoid that function, but I can make the change. |
Oh, I thought it's the recommended way by CMake. If this is a matter of preference then I think it should be determined by @danfis but not me. Thanks for the consideration, though. |
👍 I'm not a libccd developer, but do use it in other cmake-based projects. |
Merged, thanks guys. |
This refactors and enhances the cmake build to add missing targets for documentation and the test suite. It also adds the missing documentation for the cmake build, adds the necessary macros for exporting functions for building shared libraries on Windows using cmake, and adds exported targets and config files for ease of use of libccd in other cmake builds.