Update batik deps due to CVE-2018-8013 #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 15, 2018 11:15
java.lang.NoClassDefFoundError: org/apache/batik/w3c/dom/ElementTraversal see https://jira.apache.org/jira/browse/BATIK-1229 for details
|
Thanks a lot. It should be noted that untrusted svg images should not be used due to the ability of svg to include file uris to incorporate raster images. At the very least, this gives it the ability to probe the file system. Anyway, thanks again, merging now. |
|
P.S I’ll do a release over the weekend. |
|
RC17 just released. Thanks @ghenadiibatalski. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our security engineer stumbled over the CVE-2018-8013
I increased the required version to 1.10 and run into the issue BATIK-1229 so the dependency to batik-ext seems to be necessary to work around this issue.