Very large playlists cause music to stop playing when phone gets locked

[Koenvh1]

I have a playlist with 1148 songs. If I play a song from that playlist, everything works fine, until I lock my phone (or it locks itself), when the music just stops. This works fine with smaller playlists.

I expect it being due to the larger playlist using more memory, and that Android wants to clear out that memory when it locks, but I not 100% sure about that.

[matthieudecamy]

Hi,
I've been having the same issue here, but with an even larger playlist (about 5000 songs). This is making DSub very difficult to use for me as my default listening mode is to throw my starred playlist on random, which I can't do anymore.

(Note: I'd be willing to look into fixing/mitigating the issue, but I'd need some pointers on where exactly the playlists are loaded in memory.)

[Koenvh1]

I believe that's done here:

Subsonic/app/src/main/java/github/daneren2005/dsub/fragments/SelectDirectoryFragment.java

Line 389 in 9dc2539

getPlaylist(playlistId, playlistName, refresh);

The SelectDirectoryFragment is used for multiple purposes, not just for playlists.

[dverbeeck]

I am encountering this same issue. Perhaps related to library size, not playlist size? As soon as my screen goes dark, Subsonic will stop playing. It also takes an abnormally long time to start downloading any sync'd tracks after launch.

[Koenvh1]

I believe it is caused by this (and the line below it):

Subsonic/app/src/main/java/github/daneren2005/dsub/fragments/SelectDirectoryFragment.java

Line 136 in 9dc2539

outState.putSerializable(Constants.FRAGMENT_LIST, (Serializable) entries);

This gets called when the activity is about to stop (which might happens when the phone gets locked), but due to the size of the entries, it throws a TransactionTooLarge exception, which stops playback.

[dverbeeck]

Nice, now if I only knew Java I could patch it myself:( Thanks for the detail though!

…

On Tue, Apr 20, 2021, 09:54 Koen ***@***.***> wrote: I believe it is caused by this (and the line below it): https://github.com/daneren2005/Subsonic/blob/9dc25397072fd00ea73bdbeed9b46afdce366349/app/src/main/java/github/daneren2005/dsub/fragments/SelectDirectoryFragment.java#L136 This gets called when the activity is about to stop (which might happens when the phone gets locked), but due to the size of the entries, it throws a TransactionTooLarge exception, which stops playback. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#929 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALKF77RTTXZQO6QBUUGONLTTJWBRDANCNFSM4GRUZ45Q> .

[dverbeeck]

I just created a short playlist to validate this and sure enough, media does not stop. My Starred playlist may be too large. I suppose I could archive it and start fresh... feels like that's not the solve here though kek

…

On Tue, Apr 20, 2021, 09:54 Koen ***@***.***> wrote: I believe it is caused by this (and the line below it): https://github.com/daneren2005/Subsonic/blob/9dc25397072fd00ea73bdbeed9b46afdce366349/app/src/main/java/github/daneren2005/dsub/fragments/SelectDirectoryFragment.java#L136 This gets called when the activity is about to stop (which might happens when the phone gets locked), but due to the size of the entries, it throws a TransactionTooLarge exception, which stops playback. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#929 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALKF77RTTXZQO6QBUUGONLTTJWBRDANCNFSM4GRUZ45Q> .

[Koenvh1]

@dverbeeck You can try to open a different view (e.g. the Library view), which may work around it. Your mileage may vary.

[dverbeeck]

Based on this: https://developer.android.com/reference/android/os/TransactionTooLargeException it sounds like there is a 1MB limit. My starred playlist is about 1923 songs. Including paths, that could be large or small depending upon how the playlist is managed by the app. For now I'm going to fork my starred playlist kek

…

On Tue, Apr 20, 2021, 15:52 Koen ***@***.***> wrote: @dverbeeck <https://github.com/dverbeeck> You can try to open a different view (e.g. the Library view), which *may* work around it. Your mileage may vary. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#929 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALKF77QW54ETSTE2PNLKHHTTJXLOZANCNFSM4GRUZ45Q> .

[FibreTTP]

Bumping to find out if this is an issue that can be fixed.

(as it seems to be quite prevalent: #882, #1067, #1129)