Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move TempKlasses outside of test functions #224

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Move TempKlasses outside of test functions #224

merged 1 commit into from
Feb 7, 2024

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Feb 7, 2024

Closes #223.

This fixes the reported mypy crash. I was unable to produce an MVCE.

@jwodder jwodder added the tests Add or improve existing tests label Feb 7, 2024
@jwodder jwodder requested a review from satra February 7, 2024 13:33
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9b9c283) 97.66% compared to head (d96af2f) 97.66%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #224   +/-   ##
=======================================
  Coverage   97.66%   97.66%           
=======================================
  Files          18       18           
  Lines        1799     1799           
=======================================
  Hits         1757     1757           
  Misses         42       42           
Flag Coverage Δ
unittests 97.66% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic
Copy link
Member

THANK YOU!

@yarikoptic yarikoptic merged commit d8213bb into master Feb 7, 2024
69 of 77 checks passed
@yarikoptic yarikoptic deleted the gh-223 branch February 7, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

INTERNAL ERROR: maximum semantic from mypy
2 participants