Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 3.7 #193

Merged
merged 5 commits into from
Oct 24, 2023
Merged

Remove 3.7 #193

merged 5 commits into from
Oct 24, 2023

Conversation

yarikoptic
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (37c7117) 97.72% compared to head (ee7ac2a) 97.61%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #193      +/-   ##
==========================================
- Coverage   97.72%   97.61%   -0.12%     
==========================================
  Files          17       17              
  Lines        1758     1758              
==========================================
- Hits         1718     1716       -2     
- Misses         40       42       +2     
Flag Coverage Δ
unittests 97.61% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic yarikoptic changed the title Remove 3.7 from CI Remove 3.7 Oct 23, 2023
@yarikoptic
Copy link
Member Author

type checking is clearly unrelated but we do have more of 3.7 to upgrade...

@yarikoptic yarikoptic mentioned this pull request Oct 24, 2023
=== Do not change lines below ===
{
 "chain": [],
 "cmd": "codespell -w dandischema",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
@yarikoptic
Copy link
Member Author

linters -- codespell

lint: commands[0]> codespell dandischema setup.py
dandischema/tests/data/metadata/meta_000004.json:6: re-use ==> reuse
dandischema/tests/data/metadata/meta_000004old.json:413: re-use ==> reuse

I will push to this PR just because so small

@yarikoptic
Copy link
Member Author

whatever test fails to happen -- should be fixed ,but not related, thus continueing

@yarikoptic yarikoptic merged commit 15a6f87 into master Oct 24, 2023
61 of 64 checks passed
@yarikoptic yarikoptic deleted the No-3.7 branch October 24, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant