Explicitly install Python in CD workflows #2046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub Actions' switch to Ubuntu 24.04 breaks the deploy workflows. We currently use `pip` to install the `build` package prior to packaging the `dandiapi` sdist. But, we do not explicitly install the Python runtime before doing this. It looks `pip` was available on the default Ubuntu 22.04 runners, but not 24.04, so this was basically working by accident before.
jjnesbitt
approved these changes
Oct 16, 2024
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently resulting in deploy failures to staging, and will also impact production the next time a deploy happens there. https://github.com/dandi/dandi-archive/actions/runs/11349812410
GitHub Actions' switch to Ubuntu 24.04 breaks the deploy workflows. We currently use
pipto install thebuildpackage prior to packaging thedandiapisdist. But, we do not explicitly install the Python runtime before doing this. It lookspipwas available on the default Ubuntu 22.04 runners, but not 24.04, so this was basically working by accident before.