-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 12 hour cache to stats endpoint #1416
Conversation
@AlmightyYakob, is this ready for review or are there still pending tasks before it can be moved out of draft mode? |
1c49a70
to
b20a40a
Compare
@waxlamp It's now good to go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there already a configured cache backend?
The default is local memory caching. Do you think we should use a DB cache instead? |
Note: Since we're using a db cache, we'll need to run |
🚀 PR was released in |
This has been successfully performed. |
@AlmightyYakob, can you update the documentation to explain how and when to carry out this step? |
Closes #1412
Notably, this doesn't actually change how the stats are computed, it just adds a cache. Using the asset paths models to compute this results in a slightly different value than we have now. Rather than try to determine what course of action we should take (a behavior change), I just wanted to get the difference making optimization in.