Honor pager path when checking less version #1903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandavison
force-pushed
the
tweak-less-code
branch
from
2f2d7c5
to
218ced3
Compare
dandavison
commented
Nov 13, 2024
| use std::process::Command; | ||
|
|
||
| pub fn retrieve_less_version() -> Option<usize> { | ||
| if let Ok(less_path) = grep_cli::resolve_binary("less") { |
There was a problem hiding this comment.
@th1000s do you agree that it appears to be incorrect that here we use a hardcoded "less" as the name of the executable to resolve, despite one frame up the stack having obtained less_path via resolve_binary on the user's passed-in pager_path?
There was a problem hiding this comment.
Yes, your eyes do not deceive you :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.