-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add snapcraft.yaml #1542
base: main
Are you sure you want to change the base?
Add snapcraft.yaml #1542
Conversation
Hi @nicolasbock, this PR is lacking any explanation. E.g. what it does, how we know it's working correctly, etc. I don't see a |
Hi @dandavison Sorry, I should have explained this better (or at all 😉). Snaps originated at Canonical (Ubuntu) but they are not limited to Ubuntu. You can install and run snaps on most major Linux distributions. The idea behind snaps is that they provide a container like environment for the application and ship with all necessary dependencies. This makes them secure and updates are decoupled from the underlying host OS. I will add a GitHub Action to this PR so you could test the snap. |
I'll add a little to the GitHub Action in the next iteration of this PR. |
Done |
@nicolasbock Perhaps you can update the description of this PR. How is this used? |
@nicolasbock sorry to be slow here. Could you
|
This change adds a snap configuration file so that git-delta can be built as a snap. In addtion, a GitHub Action workflow is included which builds the snap and installs it inside the GitHub runner for potential functional testing. Signed-off-by: Nicolas Bock <[email protected]>
The PR provides a configuration file for a snap package. Snaps are distributed through the snapstore and are essentially containers that contain the application with all its dependencies. You can view a proof of concept listing here: https://snapcraft.io/git-delta-snap Usage of |
Thanks @dandavison The GitHub action right now builds the snap and installs it in the GitHub runner, configures git to use Installation of the snap is described in the proof of concept listing in the snap store, https://snapcraft.io/git-delta-snap. What is missing here is that once / if you approve of this PR you will have to ask the snapstore to grant you the snap name I hope this answered your questions. |
Signed-off-by: Nicolas Bock [email protected]