Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct size of default memory map #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mykmelez
Copy link
Contributor

The LMDB docs for mdb_env_set_mapsize says that the default map size is 10,485,760 bytes, i.e. 10MiB. But the DEFAULT_MAPSIZE define in the LMDB code sets the default map size to 1,048,576 bytes, i.e. 1MiB.

I submitted a patch to fix the LMDB docs in issue 8322. That issue has been open for several years, and it isn't clear whether it's the docs or the DEFAULT_MAPSIZE define that is incorrect. But I suspect the former, since the comment above DEFAULT_MAPSIZE says it's "certainly too small for any actual applications," which suggests that the smaller size was intentional.

In any case, it's worth fixing the lmdb-rs docs to specify the correct value (even if the LMDB docs specify an incorrect one).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant