src: remove tracking for exception arrow data

This is unnecessary since we only run `AppendExceptionLine()` once per exception at this point anyway. PR-URL: nodejs#17394 Reviewed-By: James M Snell <[email protected]>
danbev · Dec 5, 2017 · aeddc36 · aeddc36
1 parent 92011e4
commit aeddc36
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 14 deletions.
diff --git a/src/env.h b/src/env.h
@@ -91,7 +91,6 @@ class ModuleWrap;
   V(contextify_global_private_symbol, "node:contextify:global")               \
   V(decorated_private_symbol, "node:decorated")                               \
   V(npn_buffer_private_symbol, "node:npnBuffer")                              \
-  V(processed_private_symbol, "node:processed")                               \
   V(selected_npn_buffer_private_symbol, "node:selectedNpnBuffer")             \
   V(domain_private_symbol, "node:domain")                                     \
 

diff --git a/src/node.cc b/src/node.cc
@@ -1301,16 +1301,6 @@ void AppendExceptionLine(Environment* env,
   Local<Object> err_obj;
   if (!er.IsEmpty() && er->IsObject()) {
     err_obj = er.As<Object>();
-
-    auto context = env->context();
-    auto processed_private_symbol = env->processed_private_symbol();
-    // Do it only once per message
-    if (err_obj->HasPrivate(context, processed_private_symbol).FromJust())
-      return;
-    err_obj->SetPrivate(
-        context,
-        processed_private_symbol,
-        True(env->isolate()));
   }
 
   // Print (filename):(line number): (message).

diff --git a/src/node_contextify.cc b/src/node_contextify.cc
@@ -668,9 +668,7 @@ class ContextifyScript : public BaseObject {
         compile_options);
 
     if (v8_script.IsEmpty()) {
-      if (display_errors) {
-        DecorateErrorStack(env, try_catch);
-      }
+      DecorateErrorStack(env, try_catch);
       try_catch.ReThrow();
       return;
     }