Refactor to hide VS Code interfaces behind core services #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for upgrading monaco-editor-core to standalone/0.23.x these changes were implemented: 1) signatures alignment to standalone/0.23.x 2) editor preferences synced with standalone/0.23.x 3) Changes to theme services based on changes in 0.23.x i4) Removal of QuickOpen modules and implementing QuickInput instead
Signed-off-by: Thomas Mäder <[email protected]>
danarad05
force-pushed
the
8969-upgrade-monaco-editor-core-to-standalone-0.23.x
branch
7 times, most recently
from
9f21e75 to
ba47e37
Compare
EstherPerelman
force-pushed
the
8969-upgrade-monaco-editor-core-to-standalone-0.23.x
branch
3 times, most recently
from
07d9029 to
2697c7c
Compare
danarad05
force-pushed
the
8969-upgrade-monaco-editor-core-to-standalone-0.23.x
branch
from
699b717 to
ac6488d
Compare
EstherPerelman
force-pushed
the
8969-upgrade-monaco-editor-core-to-standalone-0.23.x
branch
3 times, most recently
from
bd54381 to
0030c1b
Compare
EstherPerelman
force-pushed
the
8969-upgrade-monaco-editor-core-to-standalone-0.23.x
branch
from
0030c1b to
de109df
Compare
EstherPerelman
force-pushed
the
8969-upgrade-monaco-editor-core-to-standalone-0.23.x
branch
6 times, most recently
from
6e8df35 to
88f1495
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Thomas Mäder [email protected]
The refactoring I mentioned in the monaco upgrade PR.
What it does
How to test
Review checklist
Reminder for reviewers