android: use more app top margin for android

[ksedgwic]

Needed so the app doesn't overlap the system bar.

A more refined solution would query the android environment for the system bar height ...

[jb55]

Hey!

On Mon, Dec 16, 2024 at 08:40:35PM GMT, Ken Sedgwick wrote: A more refined solution would query the android environment for the system bar height ... Closes: #585 --- crates/notedeck_columns/src/app.rs | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/crates/notedeck_columns/src/app.rs b/crates/notedeck_columns/src/app.rs index 656da3d..e2b083f 100644 --- a/crates/notedeck_columns/src/app.rs +++ b/crates/notedeck_columns/src/app.rs @@ -512,9 +512,26 @@ fn render_damus_mobile(app: &mut Damus, app_ctx: &mut AppContext<'_>) { }); } +fn margin_top(narrow: bool) -> f32 { + #[cfg(target_os = "android")] + { + // FIXME - query the system bar height and adjust more precisely + let _ = narrow; // suppress compiler warning on android + 40.0 + } + #[cfg(not(target_os = "android"))] + { + if narrow { + 50.0 + } else { + 0.0 + } + } +}

This is actually wildly different depending on the OS. We would need to query the insets[1] to do it properly. See: - #172 I see you mention this already and it will a bit of work, so I'll merge this for now. Reviewed-by: William Casarin ***@***.***> [1] https://developer.android.com/develop/ui/views/layout/insets