Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track the user's relay list using polling #438

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ksedgwic
Copy link
Contributor

This is the third attempt, the previous were #346 and #380

This version uses polling instead of async operations

@ksedgwic ksedgwic force-pushed the 2024-11-user-relay-list-take-three branch from d093725 to ded4752 Compare November 15, 2024 16:57
@ksedgwic ksedgwic marked this pull request as ready for review November 15, 2024 17:01
@ksedgwic ksedgwic force-pushed the 2024-11-user-relay-list-take-three branch 7 times, most recently from e1afc1b to a4de7bf Compare November 22, 2024 00:19
Is there a better way?  It seems that there is a large common subset
in all of these function signatures ...
Instead of passing a reference to the accounts Muted struct pass a
reference to a MuteFun which is called on each note and returns bool.
@ksedgwic ksedgwic force-pushed the 2024-11-user-relay-list-take-three branch from a4de7bf to 082407f Compare November 22, 2024 00:34
@jb55
Copy link
Contributor

jb55 commented Nov 22, 2024

seeing concerning warnings on this branch:

2024-11-22T20:37:47.056689Z  WARN notedeck::app: got unknown eose[..] ... 97 tracked subscriptions

97 unhandled eose's seems large

also:

2024-11-22T20:37:50.812563Z ERROR notedeck::app: wss://nostr.africa/: IO error: failed to lookup address information: nodename nor servname provided, or not known
2024-11-22T20:37:50.812570Z ERROR notedeck::app: wss://relay.current.fyi/: IO error: failed to lookup address information: nodename nor servname provided, or not known
2024-11-22T20:37:50.812575Z ERROR notedeck::app: wss://relayer.fiatjaf.com/: IO error: failed to lookup address information: nodename nor servname provided, or not known
2024-11-22T20:37:50.812581Z ERROR notedeck::app: wss://rsslay.fiatjaf.com/: IO error: failed to lookup address information: nodename nor servname provided, or not known
2024-11-22T20:37:50.958067Z ERROR notedeck::app: wss://nostr.zebedee.cloud/: IO error: invalid peer certificate contents: invalid peer certificate: CertNotValidForName
2024-11-22T20:37:51.124584Z ERROR notedeck::app: wss://relay.plebstr.com/: IO error: invalid peer certificate contents: invalid peer certificate: CertExpired
2024-11-22T20:37:51.141660Z ERROR notedeck::app: wss://nostr.onsats.org/: IO error: invalid peer certificate contents: invalid peer certificate: CertNotValidForName

which seems to be trying to fetch from a bunch of relays I don't recognize, is this trying to do the outbox model?

@jb55
Copy link
Contributor

jb55 commented Nov 22, 2024

there also seems to be log entries that are creating newlines which we should try to avoid (Muted, desired_relays)

@ksedgwic
Copy link
Contributor Author

outbox model?

Nope, just k:10002

Can you try with RUST_LOG=error,notedeck::accounts=debug,notedeck::muted=debug

@ksedgwic
Copy link
Contributor Author

Which npub are you using? I'll see if I can reproduce ...

@ksedgwic
Copy link
Contributor Author

creating newlines
fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants