Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

See highlighted segments on long-form notes #1773

Closed
Tracked by #2174
alltheseas opened this issue Nov 27, 2023 · 0 comments
Closed
Tracked by #2174

See highlighted segments on long-form notes #1773

alltheseas opened this issue Nov 27, 2023 · 0 comments
Assignees
@ericholguin
Labels
feature New feature request highlight longform
Milestone
1.9 AppStore Threads

Comments

@alltheseas
Copy link
Collaborator

alltheseas commented Nov 27, 2023 •
edited
Loading

related to
create highlights #822
see kind1 highlights #1772
@alltheseas alltheseas mentioned this issue Nov 27, 2023
Closed
@jb55 jb55 mentioned this issue Apr 19, 2024
Open
11 tasks
@alltheseas alltheseas moved this to Planned in Damus Roadmap 🛣️ Apr 22, 2024
@alltheseas alltheseas moved this from Planned to In Review in Damus Roadmap 🛣️ May 6, 2024
@alltheseas alltheseas mentioned this issue May 7, 2024
Open
15 tasks
ericholguin added a commit to ericholguin/damus that referenced this issue May 27, 2024
@ericholguin
Highlights
d0c0ea8 
This patch adds highlights (NIP-84) to Damus.

Kind 9802 are handled by all the necessary models.
We show highlighted events, longform events, and url references.
Url references also leverage text fragments to take the user to the highlighted text.

Testing
——
iPhone 15 Pro Max (17.0) Dark Mode:
https://v.nostr.build/oM6DW.mp4

iPhone 15 Pro Max (17.0) Light Mode:
https://v.nostr.build/BRrmP.mp4

iPhone SE (3rd generation) (16.4) Light Mode:
https://v.nostr.build/6GzKa.mp4
——

Closes: damus-io#2172
Closes: damus-io#1772
Closes: damus-io#1773
Closes: damus-io#2173
Closes: damus-io#2175
Changelog-Added: Highlights (NIP-84)

PATCH CHANGELOG:
V1 -> V2: addressed review comments highlights are now truncated and highlight label shown in Thread view

Signed-off-by: ericholguin <[email protected]>
@alltheseas alltheseas moved this from In Review to Done in Damus Roadmap 🛣️ Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericholguin ericholguin

Labels
feature New feature request highlight longform
Projects
Damus Roadmap 🛣️
Archived in project
Milestone
1.9 AppStore Threads
Development

No branches or pull requests
2 participants
@ericholguin @alltheseas