-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fabiangosebrink/create popup example with better API #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabianGosebrink
changed the title
Fabiangosebrink/create popup example
Fabiangosebrink/create popup example with better API
Feb 7, 2021
damienbod
reviewed
Feb 7, 2021
docs/authorizing-popup-iframe.md
Outdated
You can call the Provider's authorization endpoint in a popup or iframe instead of navigating to it in the app's parent window. | ||
This allows you to have the Provider's consent prompt display in a popup window to avoid unloading and reloading the app, | ||
or to authorize the user silently by loading the endpoint in a hidden iframe if that supported by the Provider. | ||
You can call the Provider's authorization endpoint in a popup instead of navigating to it in the app's parent window. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can authenticate tith any Open ID Connect identity provider using a popup.
docs/authorizing-popup-iframe.md
Outdated
@@ -1,14 +1,30 @@ | |||
# Authorizing in a popup or iframe | |||
# Authorizing in a popup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Authentication using a Popup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still do do:
Fixes: #931, #953, #594