subscribe startRenew after isAuthorized is true #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good, build fails to node 11 in the build config which I updated. I will merge. Thanks |
|
build works now, I will do some manual testing, and create a new npm package when this is good Thanks for the fix! Greetings Damien |
|
Thnx Damien! I'll be waiting for the new npm package. Greetings Gert-Jan |
|
released in 10.0.15 |
|
This pull request prevent initial silent login. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When silentRefresh enabled with code pkce flow results in a first call to get a token ('/connect/token') before the authorization call has been finished ('/authorize' with prompt none). The token calls after completion of the authorize call are succesful but the call before results in a '400' error.
In my usecase I wanted only to start with silentRefresh after I've been authorized.
This refers to the same issue here -> #519