Fix: returning a loginresponse and not null #1781
Conversation
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-hill-002425310-1781.centralus.azurestaticapps.net |
1 similar comment
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-hill-002425310-1781.centralus.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-hill-002425310-1781.centralus.azurestaticapps.net |
|
@timdeschryver if you want to review, feel free :) |
FabianGosebrink
requested review from
damienbod
and removed request for
damienbod
| @@ -200,7 +206,7 @@ export class CheckAuthService { | |||
| accessToken: this.authStateService.getAccessToken(config), | |||
| idToken: this.authStateService.getIdToken(config), | |||
| configId, | |||
| }; | |||
| } as LoginResponse; | |||
There was a problem hiding this comment.
I prefer not to type cast this way, instead I prefer to add a return type to the method. Because this way, we can still cheat and return a different object. With using return types we get errors if the object doesn't match the return type.
Because you asked for a review 😁
There was a problem hiding this comment.
Thanks! Will do a follow up PR ;)
Fixes #1780