-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add provideAuth for standalone applications #1643
feat: add provideAuth for standalone applications #1643
Conversation
This looks really great. @FabianGosebrink @timdeschryver Can we merge both of these PRs? I will use the docs from the the PR to test. Anything missing? Thanks for the 2 PRs |
Happy new year @damienbod and @FabianGosebrink , my best wishes 🎆 To answer #1639 (comment), yes I think we should first merge this PR and then update the other one (sorry for the confusion, but I had some time left for this PR). I don't know how to make the CI pipeline happy though. To create the standalone provider we're using the |
Hey @timdeschryver , thanks for your wishes. Happy new year and all the best for you, too. This would mean we would drop support for A14, right? Thanks |
7a70866
to
59abc50
Compare
Yea, I can't think of a way to support A14 (see latest commits where I tried some things). |
Hey @timdeschryver , thanks for this PR. I would say that we merge this one once A16 is out. Then we can drop A14 support IMHO. What do you think? |
Sounds great @FabianGosebrink ! |
97c4b5a
to
a3fdd65
Compare
@timdeschryver Thanks a million for these 2 PRs @timdeschryver @FabianGosebrink I think now is the right time to complete these PRs and add this. Good? Greetings Damien |
If we drop support for A14, we can also clean up the "this type can be dropped when Angular 14 support" comments. |
@FabianGosebrink if it's OK for you I can also create a PR to drop support for A14. |
Hey @timdeschryver , thank you so much for this. Yes, if you want to, and have time, you can create a PR for this. We should also exclude the pipeline step for V14. I am short on time until end of May and begin of June, then I have more time to help. |
This PR extracts the config into the
_provideAuth
method, which in its turn is used in the existingAuthModule
and the newprovideAuth
method (this is the best name that I can think of, feel free to suggest another method name).The config is also extracted into the
auth-config
file so it can be reused.This solution is based on how we did it with the NgRx APIs.
Part of #1599