clean up back_up_file implementation & test #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damianam
reviewed
Aug 17, 2017
easybuild/tools/filetools.py
Outdated
| """ | ||
| fn_pref, fn_suff = '', '' |
There was a problem hiding this comment.
I would use fn_prefix and fn_suffix. But that's a minor thing, everything else looks great.
|
In it goes, thanks! |
damianam
pushed a commit
that referenced
this pull request
Mar 6, 2018
update test_load, Modules v4.0 does not reload already loaded modules
damianam
pushed a commit
that referenced
this pull request
Oct 9, 2018
reworked implementation of Singularity integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First round of cleanup for easybuilders#2134, only touching
back_up_filefor now; more to come (trying to send you bite-sized PRs)Re-ran the original test after cleaning up
back_up_fileto make sure behaviour remains the same, then also cleaned up test.One thing that came to mind is that it's maybe better to back up files with a more meaningful filename like
test.txt_201708170828, i.e. date + timestamp as increasing number, and on a clash, we can simply sleep for 1 sec and try again?