-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validation #22
Validation #22
Conversation
…ce and remove nette smart object trait)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making the final
on message and handler optional opens a whole new can of worms and I'm not sure if that's wise...
Commands and/or handlers can now inherit from each other (which would probably break handler resolver logic). Also, they can be abstract and there is no validation for this.
In my previous commits I added support for custom validators. |
6f258f1
to
98c083d
Compare
4a1278a
to
95cd29c
Compare
src/StaticAnalysis/ValidateOnlyWhenTypeMatchesHandlerValidator.php
Outdated
Show resolved
Hide resolved
This hole is already open. There is nothing that would make you to even use the validators in the first place. I suggest to let this be for now. The default is alright (strict pre-configured validators for commands and events), any other scenario is up to the user. Maybe we could come up with a solution that somehow ties the validation logic and handler-resolving logic. But for now, I would leave it be. |
No description provided.