In FoundationTransport deinit, remove self as a delegate to InputStream and OutputStream to prevent EXC_BAD_ACCESS #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…am and OutputStream to prevent EXC_BAD_ACCESS
|
Good catch, Thanks! Appreciate the PR. |
|
@daltoniam Hi, when are you plan to make release with this fix? I have too many crashes in my product app(( |
Same |
FZambia
added a commit
to centrifugal/centrifuge-swift
that referenced
this pull request
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned by @nickoto in #676 and #773, Starscream will crash if a socket is deallocated before it finishes disconnecting when using
FoundationTransport. In my own testing, simply setting the delegates toinputStreamandoutputStreamtonilindeinitis effective at preventing the crash. This makes a fair amount of sense, sinceStream.delegateis anunownedproperty.