Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SSL in FoundationTransport for secure hosts #749

Conversation

nickdowell
Copy link
Contributor

This fixes connection to secure hosts such as wss://echo.websocket.org

The kCFStreamPropertySocketSecurityLevel property needs to be set for the CFStream(s) to negotiate a secure connection with the server.

This fixes connection to secure hosts such as
wss://echo.websocket.org
@michalcichon
Copy link

Hey @nickdowell, can you paste here what kind of error do you get because of this bug?

@nickdowell
Copy link
Contributor Author

Hey @michalcichon the bug causes connections to secure hosts to fail with the following:

WebSocketEvent.cancelled

Sample code for reproducing the issue was included in #748

@daltoniam
Copy link
Owner

Thanks!

@daltoniam daltoniam merged commit 9e8fcba into daltoniam:master Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants