Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for a buffer overflow when close code has not been received from the socket #697

Merged
merged 1 commit into from
Apr 6, 2020
Merged

Fix for a buffer overflow when close code has not been received from the socket #697

merged 1 commit into from
Apr 6, 2020

Conversation

mikaryyn
Copy link

I encountered the crash here where pointer only contained two bytes, [136, 39] and it was trying to read closeCode from outside the buffer. This should fix it.

@mikaryyn mikaryyn changed the base branch from feature/v4-refactor to master January 3, 2020 08:05
@daltoniam
Copy link
Owner

Thanks!

@daltoniam daltoniam merged commit 4e8973e into daltoniam:master Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikaryyn @daltoniam