Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove void parameter from onConnect, Swift4 would require passi… #333

Merged
merged 1 commit into from
May 23, 2017

Conversation

nuclearace
Copy link
Contributor

@nuclearace nuclearace commented May 21, 2017

…ng () into it

@daltoniam Noticed in the Swift 4 preview that this would require passing () into the onConnect callback, which is a bit funky.

@nuclearace
Copy link
Contributor Author

nuclearace commented May 21, 2017

This is backwards compatible.

@nuclearace nuclearace changed the title Remove void parameter from onConnect, Swift4 will would require passi… Remove void parameter from onConnect, Swift4 would require passi… May 21, 2017
@daltoniam
Copy link
Owner

Agreed. I haven't look at an actual Swift 4 snapshot yet, probably should soonish 😄. Thanks!

@daltoniam daltoniam merged commit 02718e7 into daltoniam:master May 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants