Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hangs on 401 response #161

Closed
mlilback opened this issue Jan 24, 2016 · 7 comments
Closed

Hangs on 401 response #161

mlilback opened this issue Jan 24, 2016 · 7 comments

Comments

@mlilback
Copy link

I had a typo in an authentication header and the server was returning a 401 status. The loop at the end of initStreamsWithData() became infinite. Besides handling the 401, there really should be a timeout on that loop. Or it should check the streamStatus of outpStream, which in my case was Closed.

For some reason stream() is never called. The only thing I can think of is that there is a race condition of some kind since it works occasionally when there are pauses from breakpoints.

@daltoniam
Copy link
Owner

Thanks for the report, I think I know what it is. I am working through some other conditions right now with #158 and I think this problematic behavior might be related. I will be sure to check on this as work for the fixes on the issue progress.

@LamourBt
Copy link

Hey guys do you know where the instruction file for this ... :( @daltoniam ... I didn't use this framework yet but I have the feeling this will change my life

@acmacalister
Copy link
Collaborator

@LamourBt instruction file for what? For the hanging on a 401 response? Guess we are not sure what you need help with.

@LamourBt
Copy link

I was trying to add this pod into my project however in the readme it's say see the instruction file but i could not find it, therefore I was hoping that someone could help me. @acmacalister

@acmacalister
Copy link
Collaborator

Ok, that is completely different then the issue above. To answer your question, you just need to add Starscream as a pod to your Podfile like so:

pod 'Starscream', '~> 1.1.1'

then do do a pod install

@daltoniam
Copy link
Owner

I just checked in a fix into master. Let me know if that seems to resolve it and I will do another release.

@daltoniam
Copy link
Owner

1.1.2 released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants