make it possible to control header items display from configuration file #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version has reached its end-of-life last year, https://peps.python.org/pep-0537/#lifespan.
We use the syntax from PEP 585 and PEP 604 and rely on 'from __future__ import annotations' to modernize the code base. However, not all generic aliases (e.g. Dict, List) can be replaced before Python 3.9.
Rephrase their help text and move then to a dedicated options group.
dlax
force-pushed
the
configure-header
branch
from
5c3c68d
to
f651a49
Compare
We introduce UIHeader class to hold header-specific options. Along the way, many names (variables, functions) are changed in order to make things more explicit.
In the command-line parser, options related to header information have their default value set to None in order to distinguish when the option was not specified from when it got, as it would store False then. This makes it possible to have a precedence of command-line options over the configuration file (implemented in types.UIHeader.make()). The validation of configuration options, previously in UISection, is extracted into a BaseSectionMixin and reused in new HeaderSection.
dlax
force-pushed
the
configure-header
branch
from
371d2c7
to
e45a205
Compare
SectionProxy.get*() would never actually raise NoOptionError because the 'fallback' argument defaults to None.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #405 and #406; only last tree commits are new.