Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing of 'hidden' configuration option #396

Merged
merged 2 commits into from
Aug 24, 2023
Merged

Fix parsing of 'hidden' configuration option #396

merged 2 commits into from
Aug 24, 2023

Commits on Aug 24, 2023

  1. Add a unit test for Configuration.lookup() 

    This illustrates an issue when parsing UISection from configparser's
SectionProxy: 'hidden' should be False in the test case, not None.
    @dlax
    dlax committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    97ea4c8 View commit details
    Browse the repository at this point in the history

  2. Fix parsing of 'hidden' configuration option 

    As explained in previous commit, we were setting UISection.hidden to
None when no value was present in the configuration file, instead of
keeping the default value from model. Making the parsing logic more
specific resolves the issue.
    @dlax
    dlax committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    f369b9a View commit details
    Browse the repository at this point in the history