Update to new Scalar API
#120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rozbb
commented
Mar 21, 2023
|
|
||
| impl EphemeralSecret { | ||
| /// Perform a Diffie-Hellman key agreement between `self` and | ||
| /// `their_public` key to produce a [`SharedSecret`]. | ||
| pub fn diffie_hellman(self, their_public: &PublicKey) -> SharedSecret { | ||
| SharedSecret(self.0 * their_public.0) | ||
| SharedSecret(their_public.0.mul_clamped(self.0)) |
There was a problem hiding this comment.
This is equivalent because, in the old code, self.0 was the result of Scalar::from_bits_clamped, which was unreduced.
| @@ -112,7 +111,7 @@ impl EphemeralSecret { | |||
| impl<'a> From<&'a EphemeralSecret> for PublicKey { | |||
| /// Given an x25519 [`EphemeralSecret`] key, compute its corresponding [`PublicKey`]. | |||
| fn from(secret: &'a EphemeralSecret) -> PublicKey { | |||
| PublicKey(EdwardsPoint::mul_base(&secret.0).to_montgomery()) | |||
| PublicKey(EdwardsPoint::mul_base_clamped(secret.0).to_montgomery()) | |||
There was a problem hiding this comment.
Same reasoning here, and in the multiple copies of this below
| fn from(bytes: AllowUnreducedScalarBytes) -> Scalar { | ||
| Scalar::from_bits_clamped(bytes.0) | ||
| } | ||
| } |
There was a problem hiding this comment.
We can remove this because (de)serialization of StaticSecret is all bytes now
rozbb
commented
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes all uses of
Scalar::[from_bits, from_bits_clamped}. Some comments inline.I'll update the git dependency once dalek-cryptography/curve25519-dalek#519 drops.