[version]: Allow zeroize version 1.5.0
#105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
reviewed
Feb 19, 2023
Signed-off-by: Aleksandr Petrosyan <[email protected]>
|
Applied suggestion. Would you be kind enough to approve the workflow? |
|
Oh sorry, there’s a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently cryptographic libraries are held back by the pinned dependency on
zeroize. Given that tests don't fail (either unit tests in this repo, or hyperledger/ursa), I took the liberty of unpinning the dependency in a compatible fashion.Drawbacks
If some subtle change in the behaviour of
zeroizewas introduced, and it wasn't caught by tests in Hyperledger/ursa, it might be non-trivial to find.