Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no_std to CI #289

Merged
merged 6 commits into from
Mar 21, 2023
Merged

Add no_std to CI #289

merged 6 commits into from
Mar 21, 2023

Conversation

pinkforest
Copy link
Contributor

@pinkforest pinkforest commented Mar 12, 2023

The missing test in CI:

Testing that std is not required with a target that does not have it by cargo-hack excluding default, std and serde

serde is excluded and when this test is merged and re-based into #288 it can be tested there with the fix there for serde.

ryankurte added a commit to ryankurte/ed25519-dalek that referenced this pull request Mar 20, 2023
as an alternative to dalek-cryptography#288 this updates serde `Serialize` and `Deserialize` implementations to use a
custom visitor, removing the need for `alloc` or `std` for embedded use, and making this
consistent with implementations in
[curve25519-dalek](https://github.com/dalek-cryptography/curve25519-dalek/blob/a63e14f4ded078d6bf262ba0b3f47026bdd7f7c0/src/edwards.rs#L269).

@pinkforest seems like it'd be good to have some serde tests / this should go over dalek-cryptography#289?

Co-Authored-By: Vlad Semenov <[email protected]>
@rozbb rozbb merged commit 9577d1e into dalek-cryptography:main Mar 21, 2023
ryankurte added a commit to ryankurte/ed25519-dalek that referenced this pull request Mar 21, 2023
…lize` and `Deserialize` implementations to use a

custom visitor, removing the need for `alloc` or `std` for embedded use, and making this
consistent with implementations in
[curve25519-dalek](https://github.com/dalek-cryptography/curve25519-dalek/blob/a63e14f4ded078d6bf262ba0b3f47026bdd7f7c0/src/edwards.rs#L269).

@pinkforest seems like it'd be good to have some serde tests / this should go over dalek-cryptography#289?

Co-Authored-By: Vlad Semenov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants