[WIP] Run clippy and rustfmt in CI
#237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
clippy-and-rustfmt-in-ci
branch
from
77cf6e5 to
5da678a
Compare
|
Will wait for #224 to land before trying to fix The good news is that the code is already |
tarcieri
changed the title
clippy and rustfmt in CIclippy and rustfmt in CI
|
Clippy needs clippy fixes, I ran them here w/ CI add: |
Closed
|
Closing in favor of #244 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runs
clippypinned to the latest stable release (1.65)This keeps CI deterministic and avoids potential breakages from new Rust releases, while also ensuring we currently pass all of the latest lints.