Fix warnings and add -D warnings check in CI
#226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
fix-warnings
branch
2 times, most recently
from
6665342 to
f24a14d
Compare
- Eliminates dead code left over from #205 - Adds `-D warnings` in CI so that warnings are treated as errors. This ensures code must be warning-free to pass CI.
tarcieri
force-pushed
the
fix-warnings
branch
from
f24a14d to
1789f19
Compare
tarcieri
commented
Nov 20, 2022
| @@ -54,7 +54,7 @@ std = ["curve25519-dalek/std", "ed25519/std", "serde_crate/std", "sha2/std", "ra | |||
| alloc = ["curve25519-dalek/alloc", "rand/alloc", "zeroize/alloc"] | |||
| nightly = ["curve25519-dalek/nightly"] | |||
| serde = ["serde_crate", "serde_bytes", "ed25519/serde"] | |||
| batch = ["merlin", "rand"] | |||
| batch = ["merlin", "rand/std"] | |||
There was a problem hiding this comment.
It needs std for rand::thread_rng
Merged
rozbb
reviewed
Nov 21, 2022
| @@ -57,6 +57,8 @@ mod ed25519_benches { | |||
| fn verify_batch_signatures(c: &mut Criterion) { | |||
| static BATCH_SIZES: [usize; 8] = [4, 8, 16, 32, 64, 96, 128, 256]; | |||
|
|
|||
| // TODO: use BenchmarkGroups instead. | |||
| #[allow(deprecated)] | |||
There was a problem hiding this comment.
I address this and the std stuff in #220. Will rebase soon
|
Thanks! The warnings have been a bit annoying |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-D warningsin CI so that warnings are treated as errors. This ensures code must be warning-free to pass CI.