Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump curve25519-dalek to v4.0.0-pre (via git) #223

Merged
merged 1 commit into from
Nov 20, 2022

Conversation

tarcieri
Copy link
Contributor

@tarcieri tarcieri commented Nov 19, 2022

Also bumps these corresponding dependencies which are needed for everything to compile with this update:

  • merlin v3.0
  • rand v0.8
  • rand_core v0.6
  • sha2 v0.10

@tarcieri tarcieri force-pushed the curve25519-dalek/v4.0.0-pre branch from 8753a66 to 2e4d37d Compare November 19, 2022 21:41
@tarcieri tarcieri mentioned this pull request Nov 20, 2022
@rozbb rozbb changed the base branch from main to release/2.0 November 20, 2022 08:15
@rozbb rozbb marked this pull request as ready for review November 20, 2022 08:15
@rozbb
Copy link
Contributor

rozbb commented Nov 20, 2022

Looks good. Was there a reason this was a WIP?

@tarcieri
Copy link
Contributor Author

Just the failing CI jobs, at least one of which seems to be addressed by an open PR

@tarcieri tarcieri force-pushed the curve25519-dalek/v4.0.0-pre branch from 2e4d37d to 880a143 Compare November 20, 2022 15:31
@tarcieri tarcieri changed the title [WIP] Bump curve25519-dalek to v4.0.0-pre (via git) Bump curve25519-dalek to v4.0.0-pre (via git) Nov 20, 2022
@tarcieri
Copy link
Contributor Author

Removed WIP if you consider the build failures unrelated

@tarcieri tarcieri force-pushed the curve25519-dalek/v4.0.0-pre branch from 9bbf09a to ccfe014 Compare November 20, 2022 18:03
Removes the `u32_backend`/`u64_backend` features which are now selected
automatically. See dalek-cryptography/curve25519-dalek#/428.

Also bumps these corresponding dependencies which are needed for
everything to compile with this update:

- `merlin` v3.0
- `rand` v0.8
- `rand_core` v0.6
- `sha2` v0.10
@tarcieri tarcieri force-pushed the curve25519-dalek/v4.0.0-pre branch from ccfe014 to 98fe962 Compare November 20, 2022 18:08
@tarcieri
Copy link
Contributor Author

@rozbb should be ready now, even fixed the test failures

@rozbb rozbb merged commit f7cbeee into release/2.0 Nov 20, 2022
@tarcieri tarcieri deleted the curve25519-dalek/v4.0.0-pre branch November 20, 2022 21:04
This was referenced Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants