Feature-gated more precomputed tables #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still had some size-8 NAF tables lying around for the
aA + bBvartime procedure. This puts those tables behind theprecomputed-tablesfeature gate.New bench results for
precomputed-tableson my M1 machine, using u64 serial backend:65% speedup on fixed-base mul, 9% speedup on
aA + bBvartime mul. And the.rlibfile went from 1.4MB to 758KB (54% of original).Weirdly, there was a 9% slowdown on vartime fixed-based multiscalar mul over 512 elems, but a 6% speedup on the same thing over 1024 elements. Go figure.