Add clamp function to Scalar struct
#498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeStrashko
changed the title
clamp function to Scalar struct (#497)clamp function to Scalar struct
|
Just as a general impression: you're making a lot of superfluous copies of secret key material. IMO when dealing with key material you should try to make as few copies as possible. LLVM will most likely optimize them all away, but it would be better if you wrote the code in such a way it didn't make copies in the first place. |
tarcieri
reviewed
Jan 8, 2023
tarcieri
reviewed
Jan 8, 2023
tarcieri
reviewed
Jan 8, 2023
tarcieri
reviewed
Jan 8, 2023
tarcieri
reviewed
Jan 8, 2023
tarcieri
approved these changes
Jan 8, 2023
tarcieri
reviewed
Jan 9, 2023
tarcieri
reviewed
Jan 9, 2023
|
FWIW, this is a great writeup on clamping: https://www.reddit.com/r/crypto/comments/107i1ar/why_do_we_need_to_clamp_25519_keys_when_we/j3nj8y5/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scalar::from_bytesto removemut Scalarvariable (I think this way it's a bit more clean)