Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ff and group traits #473

Closed
wants to merge 5 commits into from
Closed

Implement ff and group traits #473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f95de3a
Implement `ff` traits for `Scalar`
str4d Dec 12, 2022
1e25bfc
Move `ff` traits behind `group` feature flag
str4d Dec 19, 2022
dccdb92
Implement `group` traits for `RistrettoPoint`
str4d Dec 19, 2022
715e438
Implement `group` traits for `EdwardsPoint`
str4d Dec 19, 2022
926b33e
Deduplicate constant-time and non-constant-time decompression code
str4d Dec 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ jobs:
- run: ${{ matrix.deps }}
- run: cargo test --target ${{ matrix.target }} --no-default-features
- run: cargo test --target ${{ matrix.target }}
- run: cargo test --target ${{ matrix.target }} --features group
- run: cargo test --target ${{ matrix.target }} --features serde
- env:
RUSTFLAGS: '--cfg curve25519_dalek_backend="fiat"'
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ major series.
version.
* Relax the `zeroize` dependency to `^1`
* Update the edition from 2015 to 2021
* Add implementations of the `ff` and `group` traits, behind the `group` feature flag.

## 3.x series

Expand Down
2 changes: 2 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ required-features = ["rand_core"]

[dependencies]
cfg-if = "1"
group_crate = { version = "0.13", default-features = false, optional = true, package = "group" }
rand_core = { version = "0.6.4", default-features = false, optional = true }
digest = { version = "0.10", default-features = false, optional = true }
subtle = { version = "2.3.0", default-features = false }
Expand All @@ -65,6 +66,7 @@ packed_simd = { version = "0.3.4", package = "packed_simd_2", features = ["into_
[features]
default = ["alloc"]
alloc = ["zeroize/alloc"]
group = ["group_crate", "rand_core"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With #485 landed this can now be:

Suggested change
group = ["group_crate", "rand_core"]
group = ["dep:group", "rand_core"]


[profile.dev]
opt-level = 2
Loading