Fix --no-default-features test warnings; consolidate CI jobs
#461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
tarcieri
force-pushed
the
fix-warnings-and-consolidate-ci-jobs
branch
from
06be731 to
b4b3083
Compare
Is there a flag somewhere that errors if it sees a warning? |
rozbb
approved these changes
Dec 8, 2022
|
It’s |
Previously `cargo test --no-default-features` would succeed but with warnings. This commit fixes all of those warnings and tests `--no-default-features` in CI to ensure that in perpetuity. It moves the `tests-default-serde` into the `test` job which reduces the total number of job runners needed and reuses intermediate artifacts which should improve build times. It removes `test-alloc-u32` as this case is already covered by the `test` job when it runs `cargo test --target i686-unknown-linux-gnu` as the `alloc` feature alone is now enabled by default.
tarcieri
force-pushed
the
fix-warnings-and-consolidate-ci-jobs
branch
from
b4b3083 to
fe6a4b9
Compare
tarcieri
commented
Dec 8, 2022
| @@ -8,6 +8,7 @@ on: | |||
|
|
|||
| env: | |||
| CARGO_TERM_COLOR: always | |||
| RUSTFLAGS: '-D warnings' | |||
There was a problem hiding this comment.
Added -D warnings.
FWIW ed25519-dalek already has it
|
@rozbb added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
cargo test --no-default-featureswould succeed but with warnings.This commit fixes all of those warnings and tests
--no-default-featuresin CI to ensure that in perpetuity.It moves the
tests-default-serdeinto thetestjob which reduces the total number of job runners needed and reuses intermediate artifacts which should improve build times.It removes
test-alloc-u32as this case is already covered by thetestjob when it runscargo test --target i686-unknown-linux-gnuas theallocfeature alone is now enabled by default.