Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small rust fixes #290

Merged
merged 2 commits into from
Oct 7, 2019
Merged

Small rust fixes #290

merged 2 commits into from
Oct 7, 2019

Conversation

huitseeker
Copy link
Contributor

Fixes:

  • matches that boil down to a ? operator
  • clippy lints not against the repo's style

See individual commit messages

@huitseeker
Rust added support for the ? operator on Option in 1.22
023fdf2 
This converts a few instances of an early-returning unwrap to it.
@huitseeker
Rust fixes for some clippy warnings
9785f56 
Clippy lints with instances in the project but NOT applied here, since they seem consistently at odds with the projects' style:
- [unreadable literal](https://rust-lang.github.io/rust-clippy/master/#unreadable_literal)
- [cast lossless](https://rust-lang.github.io/rust-clippy/master/#cast_lossless)
- [assign op pattern](https://rust-lang.github.io/rust-clippy/master/#assign_op_pattern)
@hdevalence hdevalence changed the base branch from master to develop October 7, 2019 20:55
hdevalence
hdevalence approved these changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@hdevalence hdevalence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hdevalence hdevalence merged commit 8602ec0 into dalek-cryptography:develop Oct 7, 2019
pinkforest pushed a commit to pinkforest/curve25519-dalek that referenced this pull request Jun 27, 2023
@smoelius
Remove two unnecessary into_iter (dalek-cryptography#290)
7dc1bbd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hdevalence hdevalence hdevalence approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huitseeker @hdevalence