-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix link to AVX2 docs #275
Fix link to AVX2 docs #275
Conversation
Hi -- what nightly are you using? Recent nightlies changed the path root for |
Hmm I am using the latest nightly. I tried changing the path to be "docs/avx2-notes.md" and "docs/parallel-formulas.md" and that didn't fix it:
|
Also, your links indicate that the new root is relative to the current file, not the crate root, so I think my fix makes sense by making the paths have the additional |
Uh oh, that's bad news, I thought it was already fixed.... let me dig into this |
Yep, you're absolutely right, sorry -- I think that 5c18bfb didn't fix it, because I just added one |
Hmm, the CI job did print an error, but it was reported as passing: https://travis-ci.org/dalek-cryptography/curve25519-dalek/jobs/566199718 |
@Pratyush thanks for spotting this -- could you amend the commit to also update to |
0baad83
to
912fe47
Compare
Force-pushed; should be fixed now, I think? |
Great, I confirmed that running |
Awesome =) |
* Added items to changelog for 2.0 release * Removed unnecessary uses of std in doctests * Gated `Context` behind `digest` * Fixed noncompiling doctest when only `digest` is enabled * README feature flag list mostly done * Copied changelog to readme * Redid the malleability section in README * Added CONTRIBUTING.md * Bumped version number to 2.0.0-pre.0; small changes to README * Updated changelog for dalek-cryptography#277 * Added pem feature description Co-authored-by: pinkforest(she/her) <[email protected]>
Currently the library doesn't compile on
nightly
when theavx2_backend
is enabled; this PR fixes it by fixing the links to the relevant docs.