Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rand dependency to rand_os, update rand_core #262

Closed
wants to merge 1 commit into from

Conversation

zone117x
Copy link

Remove dependency on monolithic rand lib.

@hdevalence
Copy link
Contributor

Hi there, thanks for the PR! Unfortunately I don't think we can merge this, because it changes the rand_core version, and the rand_core traits are part of this crate's public API (and so they're covered by this crate's stability guarantees).

We could update the rand versions in a version 2.0 of this crate, but there's a lot of churn in the rand crates so I would rather wait until they release a 1.0 version.

@hdevalence hdevalence closed this Jun 22, 2019
@hdevalence hdevalence mentioned this pull request Jul 12, 2019
pinkforest added a commit to pinkforest/curve25519-dalek that referenced this pull request Jun 27, 2023
* Make rand_core optional
* Bench requires features rand_core
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants