Multiscalar multiplication with precomputation. #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdevalence
force-pushed
the
updated-precomputation
branch
from
7d29d34 to
27daa52
Compare
This doesn't (yet) give any speedup over the non-precomputed multiscalar multiplication, and it's not clear that it's a good idea to commit to supporting it in the future. Removing it means that it's not committed-to as part of the public API, but the source is still there in the tree if we want to revisit it later.
This avoids potentially misleading benchmark results where the memory cost of precomputation becomes "free" as re-running the benchmark loop lifts exactly the required table entries into the highest-level caches.
hdevalence
force-pushed
the
updated-precomputation
branch
from
29687b6 to
47967b4
Compare
|
I removed the constant-time precomputation support for the reason mentioned in the commit:
|
|
The CI failures are related to issues in the rand crate again, merging this before fixing them. |
pinkforest
pushed a commit
to pinkforest/curve25519-dalek
that referenced
this pull request
Jun 27, 2023
Change from_bytes methods to take fixed-size array argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #125.
Adds two traits,
PrecomputedMultiscalarMulandVartimePrecomputedMultiscalarMul, provides implementations forEdwardsPointsandRistrettoPoints, and reworks the benchmarks to provide precomputation timings.