Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop benchmarks from Travis #123

Merged

Conversation

hdevalence
Copy link
Contributor

They take a lot longer to run now.

@tarcieri
Copy link
Contributor

tarcieri commented Apr 4, 2018

If you marked them as allow_failures in matrix, you could also add fast_finish: true to matrix and they would continue to run, but not block merges.

@hdevalence
Copy link
Contributor Author

That's a good suggestion. I'm not sure it makes sense to run benchmarks on Travis anyways, since there's no control over what the hardware is doing, so I'm not sure how meaningful it is. @isislovecruft ?

@tarcieri
Copy link
Contributor

tarcieri commented Apr 4, 2018

Yeah I have generally stopped benchmarking on Travis because the results have way too much variability for me to care

@isislovecruft isislovecruft self-requested a review April 4, 2018 22:19
Copy link
Member

@isislovecruft isislovecruft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, I've never look at the Travis bench results because they don't mean much.

@hdevalence hdevalence merged commit 05c1d07 into dalek-cryptography:develop Apr 4, 2018
@hdevalence hdevalence deleted the feature/drop-bench-travis branch April 4, 2018 22:23
pinkforest added a commit to pinkforest/curve25519-dalek that referenced this pull request Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants