Skip to content

Commit

Permalink
Relax zeroize dependency and bump MSRV (#412)
Browse files Browse the repository at this point in the history
  • Loading branch information
rozbb authored Oct 17, 2022
1 parent c3ed99b commit 51572da
Show file tree
Hide file tree
Showing 4 changed files with 23 additions and 6 deletions.
18 changes: 13 additions & 5 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -101,18 +101,26 @@ jobs:
args: --features "nightly"

msrv:
name: Current MSRV is 1.41
name: Current MSRV is 1.56.1
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
# First run `cargo +nightly -Z minimal-verisons check` in order to get a
# Cargo.lock with the oldest possible deps
- uses: actions-rs/toolchain@v1
with:
profile: minimal
toolchain: 1.41
toolchain: nightly
override: true
- uses: actions-rs/cargo@v1
- run: cargo -Z minimal-versions check --no-default-features --features "fiat_u64_backend,serde"
# Now check that `cargo build` works with respect to the oldest possible
# deps and the stated MSRV
- uses: actions-rs/toolchain@v1
with:
command: build
profile: minimal
toolchain: 1.56.1
override: true
- run: cargo build --no-default-features --features "fiat_u64_backend,serde"

bench:
name: Check that benchmarks compile
Expand All @@ -128,4 +136,4 @@ jobs:
with:
command: bench
# This filter selects no benchmarks, so we don't run any, only build them.
args: "DONTRUNBENCHMARKS"
args: "nonexistentbenchmark"
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ major series.

* Update the `rand_core` dependency version and the `rand` dev-dependency
version.
* Relax the `zeroize` dependency to `^1`
* Update the MSRV from 1.41 to 1.56.1

## 3.x series

Expand Down
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ serde = { version = "1.0", default-features = false, optional = true, features =
# The original packed_simd package was orphaned, see
# https://github.com/rust-lang/packed_simd/issues/303#issuecomment-701361161
packed_simd = { version = "0.3.4", package = "packed_simd_2", features = ["into_bits"], optional = true }
zeroize = { version = ">=1, <1.4", default-features = false }
zeroize = { version = "1", default-features = false }
fiat-crypto = { version = "0.1.6", optional = true}

[features]
Expand Down
7 changes: 7 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,13 @@ builds using `--no-default-features`. Note that this requires explicitly
selecting an arithmetic backend using one of the `_backend` features.
If no backend is selected, compilation will fail.


# Minimum Supported Rust Version

This crate requires Rust 1.56.1 at a minimum. 3.x releases of this crate supported an MSRV of 1.41.

In the future, MSRV changes will be accompanied by a minor version bump.

# Safety

The `curve25519-dalek` types are designed to make illegal states
Expand Down

0 comments on commit 51572da

Please sign in to comment.