-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement: Make BYD protocol more robust for offgrid use #751
Conversation
10 seconds is too short, as the battery in a Volvo, for example, only starts after 10 seconds. Then the inverter takes about 10-20 seconds to begin sending data over the CAN. Please increase this time to 60 seconds. |
@GoSmartEV , changed to 60 seconds in commit b81e0f5 |
It doesn’t recognize it in the right way the battery and invertor |
Hmm, not really sure how to solve this. If this PR did not help anything, I suggest we close it as wont do for now, and investigate your startup issue more in detail |
the program does not correctly determine where the battery and where the inverter is But the CAN message are at the correct this problem was in the oldest firmware too, it feels like it’s just mixed up |
So the problem is most likely related to OFFGRID use, incase the Inverter is not powered on, the messages sent towards it will result in the board going into CAN_TX_FAILURE. We need to add an OFFGRID toggle, where the code ignores total CAN failures and properly allows the system to start |
Yes, this helps, and yes, it’s working for off grid 👌🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What
This PR makes the BYD protocol easier to use for Offgrid mode
Why
If emulator starts battery, but is unable to see inverter right away, it will go into Fault mode
How
We now wait until we have seen a BYD inverter message before we start sending anything towards the inverter. This prevents any CAN_TX_FAILURE messages from happening.