Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove classfile from root of tigris jar #7

Open
mitchelkuijpers opened this issue Oct 10, 2018 · 4 comments
Open

Remove classfile from root of tigris jar #7

mitchelkuijpers opened this issue Oct 10, 2018 · 4 comments

Comments

@mitchelkuijpers
Copy link

For some reason there is a JSONStringEscapingInputStream.class file in the root of the jar of tigris 0.1.1. This breaks using cheshire or tigris in an OSGI bundle. Could you cut a new release without the classfile in the root of the jar?

@dakrone
Copy link
Owner

dakrone commented Oct 14, 2018

Huh, I didn't do anything special when I generated it, I'll have to check into this and see if I am able to remove it.

@mitchelkuijpers
Copy link
Author

I just built 1.2-SNAPSHOT and there it doesn't occur. Maybe before releasing you forgot to clean the target folder?

@dakrone
Copy link
Owner

dakrone commented Oct 22, 2018

@mitchelkuijpers okay I released 0.1.2, can you give it a shot and see if it fixes the problem for you?

@mitchelkuijpers
Copy link
Author

@dakrone it now contains Build-Jdk: 11 in the META-INF/MANIFEST.MF which fails because we still need to run on JDK-8. But it fixes the other problem.

aiba added a commit to aiba/cheshire that referenced this issue Sep 2, 2019
aiba added a commit to aiba/cheshire that referenced this issue Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants